Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find first the exact SDK request and add the forcing of 32 bit build to VS 2005 #276

Merged
merged 1 commit into from
May 15, 2017

Conversation

eyalg1972
Copy link

Currently when I specify to use version 6.0A it search in the loop on-

C:/Program Files (x86)/Windows Kits
C:/Program Files (x86)/Microsoft SDKs/Windows
C:/Program Files/Windows Kits
C:/Program Files/Microsoft SDKs/Windows

Now, since it ignores only higher versions of SDK (Not Lower), It detect version 5.0 under
C:\Program Files (x86)\Microsoft SDKs\Windows

Before it detects-
C:\Program Files\Microsoft SDKs\Windows\v6.0A
This means it use version 5.0 when I asked for 6.0A.

The solution is to do two loops instead of one-

  1. Serach for exact SDK version
  2. If no SDK was found in the first loop- Try to find lower version

I am not sure why we need lower version of SDK, but this is how it was implemented first, so I did not want to cancel this option.

@ctrueden ctrueden merged commit 5e955e0 into maven-nar:master May 15, 2017
@ctrueden
Copy link
Contributor

ctrueden commented May 15, 2017

Thanks @eyalg1972!

Note that I did some follow-up style fixes to Msvc in general in 1dd0fa0.

@eyalg1972 eyalg1972 deleted the ExactSDK branch May 18, 2017 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants